ChessUSA.com TalkChess.com
Hosted by Your Move Chess & Games
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Stockfish - material balance/imbalance evaluation
Post new topic    TalkChess.com Forum Index -> Computer Chess Club: Programming and Technical Discussions Flat
View previous topic :: View next topic  
Author Message
Eelco de Groot



Joined: 12 Mar 2006
Posts: 2591
Location: Groningen

PostPost subject: Re: Stockfish - material balance/imbalance evaluation    Posted: Sat May 08, 2010 4:53 pm Reply to topic Reply with quote

mcostalba wrote:
Ralph Stoesser wrote:

@Marco, at least your hidden automatic tuning machine cannot fix bugs, but we humans can. Wink
evaluate.cpp, line 145



Wow ! This is a bug, but to properly fix we need to retune all !

If we rewrite the labes as should be:

Code:

  const Score ThreatBonus[8][8] = {
      { Z, Z, Z, Z, Z, Z, Z, Z },
      { Z, S(18,37),       Z, S(37,47), S(55,97), S(55,97), Z, Z }, // not used
      { Z, S(18,37), S(37,47),       Z, S(55,97), S(55,97), Z, Z }, // KNIGHT attacks
      { Z, S( 9,27), S(27,47), S(27,47),       Z, S(37,47), Z, Z }, // BISHOP attacks
      { Z, S(27,37), S(27,37), S(27,37), S(27,37),       Z, Z, Z }, // ROOK attacks
      { Z, Z, Z, Z, Z, Z, Z, Z }, // QUEEN attacks
      { Z, Z, Z, Z, Z, Z, Z, Z }, // not used
      { Z, Z, Z, Z, Z, Z, Z, Z }  // not used
  };


we see that evaluation for the queen is completely missing ! and that also evaluation for a KNIGHT attacking a BISHOP, for a BISHOP attacking a ROOK and a ROOK attacking a QUEEN are all missing.

So we need to retune all !

Thanks, yes, this is a case where we will need to use autmatic tuning Wink


Is this labeling correct?

Code:

  const Score ThreatBonus[8][8] = {
      { Z, Z, Z, Z, Z, Z, Z, Z }, // BISHOP PAIR attacks
      { Z, S(18,37),       Z, S(37,47), S(55,97), S(55,97), Z, Z }, // PAWN
attacks
      { Z, S(18,37), S(37,47),       Z, S(55,97), S(55,97), Z, Z }, // KNIGHT attacks
      { Z, S( 9,27), S(27,47), S(27,47),       Z, S(37,47), Z, Z }, // BISHOP attacks
      { Z, S(27,37), S(27,37), S(27,37), S(27,37),       Z, Z, Z }, // ROOK attacks
      { Z, Z, Z, Z, Z, Z, Z, Z }, // QUEEN attacks
      { Z, Z, Z, Z, Z, Z, Z, Z }, // KING attacks
      { Z, Z, Z, Z, Z, Z, Z, Z }  // not used
  };


I find it still very strange that the table still works with Knight-Knight attacks, Bishop-Bishop coefficients that are not zero and others that should be zero. I have not tried the new version yet. The coefficients are small but still strange that it could be tuned at all... I had been looking at those Z,Z,Z tables but assumed somehow that the Bishop pair was not included in the table Embarassed Rainbow Serpent by the way has KING attacks but if this interpretation is correct it was actually QUEEN attacks Embarassed Embarassed ? If so I can say that QUEEN attacks should work Smile Don't know about King attacks now... If this only explains why Tord Marco And Joona coud not find more elos in the table, that is not so surprising anymore then Idea Thanks to Ralph! One more bug find like this and Stockfish can overtake Rybka 4 when she comes out Very Happy

Eelco
_________________
Debugging is twice as hard as writing the code in the first
place. Therefore, if you write the code as cleverly as possible, you
are, by definition, not smart enough to debug it.
-- Brian W. Kernighan
Back to top
View user's profile Send private message
Display posts from previous:   
Subject Author Date/Time
Stockfish - material balance/imbalance evaluation Ralph Stoesser Wed May 05, 2010 4:39 pm
      Re: Stockfish - material balance/imbalance evaluation Marco Costalba Wed May 05, 2010 4:48 pm
            Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Wed May 05, 2010 5:37 pm
                  Re: Stockfish - material balance/imbalance evaluation Marco Costalba Wed May 05, 2010 5:47 pm
      Re: Stockfish - material balance/imbalance evaluation Jan Brouwer Wed May 05, 2010 5:49 pm
            Re: Stockfish - material balance/imbalance evaluation Eelco de Groot Wed May 05, 2010 7:25 pm
                  Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Wed May 05, 2010 8:02 pm
                        Re: Stockfish - material balance/imbalance evaluation Eelco de Groot Wed May 05, 2010 10:10 pm
                              Re: Stockfish - material balance/imbalance evaluation Milos Stanisavljevic Wed May 05, 2010 10:30 pm
                                    Re: Stockfish - material balance/imbalance evaluation Eelco de Groot Wed May 05, 2010 10:47 pm
                                    Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Wed May 05, 2010 11:27 pm
                                          Re: Stockfish - material balance/imbalance evaluation Eelco de Groot Thu May 06, 2010 1:23 am
                                                Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Thu May 06, 2010 9:07 am
                                                      Re: Stockfish - material balance/imbalance evaluation Sven Schüle Thu May 06, 2010 9:31 am
                                                            Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Thu May 06, 2010 9:52 am
                                                                  Re: Stockfish - material balance/imbalance evaluation Sven Schüle Thu May 06, 2010 10:48 am
                                                                        Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Thu May 06, 2010 12:08 pm
                                                                              Re: Stockfish - material balance/imbalance evaluation Tord Romstad Thu May 06, 2010 8:24 pm
                                                      Re: Stockfish - material balance/imbalance evaluation Eelco de Groot Thu May 06, 2010 1:19 pm
                                                Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Fri May 07, 2010 9:34 pm
                                                      Re: Stockfish - material balance/imbalance evaluation Marco Costalba Sat May 08, 2010 12:48 pm
                                                            Re: Stockfish - material balance/imbalance evaluation Eelco de Groot Sat May 08, 2010 1:47 pm
                                                            Re: Stockfish - material balance/imbalance evaluation Marcel van Kervinck Sat May 08, 2010 2:01 pm
                                          Re: Stockfish - material balance/imbalance evaluation Marco Costalba Thu May 06, 2010 11:40 am
                              Re: Stockfish - material balance/imbalance evaluation Eelco de Groot Wed May 05, 2010 10:42 pm
      Re: Stockfish - material balance/imbalance evaluation Joona Kiiski Wed May 05, 2010 7:54 pm
            Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Wed May 05, 2010 8:28 pm
            Re: Stockfish - material balance/imbalance evaluation Larry Kaufman Sun May 27, 2012 7:31 pm
      Re: Stockfish - material balance/imbalance evaluation Tord Romstad Thu May 06, 2010 8:16 pm
            Re: Stockfish - material balance/imbalance evaluation James Coit Thu May 06, 2010 10:13 pm
            Re: Stockfish - material balance/imbalance evaluation Vratko Polák Thu May 06, 2010 11:38 pm
            Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Fri May 07, 2010 12:15 am
                  Re: Stockfish - material balance/imbalance evaluation Marco Costalba Fri May 07, 2010 5:39 am
                        Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Fri May 07, 2010 8:09 am
                              Re: Stockfish - material balance/imbalance evaluation Marco Costalba Fri May 07, 2010 8:25 am
                                    Re: Stockfish - material balance/imbalance evaluation Sven Schüle Fri May 07, 2010 9:48 am
                                          Re: Stockfish - material balance/imbalance evaluation Sven Schüle Fri May 07, 2010 10:31 am
                                          Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Fri May 07, 2010 10:54 am
                                          Re: Stockfish - material balance/imbalance evaluation Miguel A. Ballicora Fri May 07, 2010 10:31 pm
                                                Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Sat May 08, 2010 1:33 pm
                                                      Re: Stockfish - material balance/imbalance evaluation Marco Costalba Sat May 08, 2010 2:29 pm
                                                            Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Sat May 08, 2010 4:24 pm
                                                                  Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Sat May 08, 2010 7:54 pm
                                                                        Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Sun May 09, 2010 3:19 pm
                                                                              Re: Stockfish - material balance/imbalance evaluation Marco Costalba Sun May 09, 2010 4:47 pm
                                                                                    Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Sun May 09, 2010 7:51 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Marco Costalba Sun May 09, 2010 10:47 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Sun May 09, 2010 11:22 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Marco Costalba Mon May 10, 2010 4:58 am
                                                                                          Re: Stockfish - material balance/imbalance evaluation Sven Schüle Mon May 10, 2010 7:39 am
                                                                                          Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Mon May 10, 2010 10:22 am
                                                                                          Re: Stockfish - material balance/imbalance evaluation Eelco de Groot Mon May 10, 2010 5:04 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Mon May 10, 2010 9:35 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Marco Costalba Tue May 11, 2010 11:19 am
                                                                                          Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Tue May 11, 2010 1:51 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Tue May 11, 2010 9:38 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Marco Costalba Wed May 12, 2010 5:05 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Robert Hyatt Wed May 12, 2010 6:14 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Marco Costalba Wed May 12, 2010 6:39 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Thu May 13, 2010 12:51 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Wed May 12, 2010 8:13 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Wed May 12, 2010 9:15 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Marco Costalba Wed May 12, 2010 9:34 pm
                                                                                          Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Wed May 12, 2010 10:02 pm
                                                            Re: Stockfish - material balance/imbalance evaluation Eelco de Groot Sat May 08, 2010 4:53 pm
                                                                  Re: Stockfish - material balance/imbalance evaluation Ralph Stoesser Sat May 08, 2010 7:03 pm
            Re: Stockfish - material balance/imbalance evaluation Vincent Diepeveen Wed Jul 28, 2010 6:10 pm
                  Re: Stockfish - material balance/imbalance evaluation Milos Stanisavljevic Wed Jul 28, 2010 6:24 pm
                        Re: Stockfish - material balance/imbalance evaluation grzegorzs Thu Aug 05, 2010 5:36 pm
                  Re: Stockfish - material balance/imbalance evaluation Dann Corbit Wed Jul 28, 2010 6:43 pm
                        Re: Stockfish - material balance/imbalance evaluation Vincent Diepeveen Wed Jul 28, 2010 7:43 pm
                              Re: Stockfish - material balance/imbalance evaluation Vincent Diepeveen Wed Jul 28, 2010 7:44 pm
                                    Re: Stockfish - material balance/imbalance evaluation Joona Kiiski Wed Jul 28, 2010 7:55 pm
                                          Re: Stockfish - material balance/imbalance evaluation Vincent Diepeveen Wed Jul 28, 2010 8:30 pm
                                                Re: Stockfish - material balance/imbalance evaluation Milos Stanisavljevic Wed Jul 28, 2010 9:30 pm
                                                      Re: Stockfish - material balance/imbalance evaluation Vincent Diepeveen Wed Jul 28, 2010 10:11 pm
                                                            Re: Stockfish - material balance/imbalance evaluation Milos Stanisavljevic Wed Jul 28, 2010 10:31 pm
                                                                  Re: Stockfish - material balance/imbalance evaluation Vincent Diepeveen Wed Jul 28, 2010 10:57 pm
                                                            Crazy talk Ben-Hur Carlos Langoni Wed Jul 28, 2010 11:07 pm
                                                                  Re: Crazy talk Vincent Diepeveen Wed Jul 28, 2010 11:36 pm
                                                Re: Stockfish - material balance/imbalance evaluation Ben Stoker Wed Jul 28, 2010 10:07 pm
                                                      Re: Stockfish - material balance/imbalance evaluation Vincent Diepeveen Sun Aug 08, 2010 1:54 pm
                              Re: Stockfish - material balance/imbalance evaluation Robert Hyatt Wed Jul 28, 2010 8:27 pm
                                    Re: Stockfish - material balance/imbalance evaluation Dann Corbit Wed Jul 28, 2010 9:30 pm
                              Re: Stockfish - material balance/imbalance evaluation Wylie Garvin Tue Aug 10, 2010 10:00 pm
      Re: Stockfish - material balance/imbalance evaluation Tu Ngoc Trung Sun May 27, 2012 2:22 am
            Re: Stockfish - material balance/imbalance evaluation Ferdinand Mosca Sun May 27, 2012 10:01 am
                  Re: Stockfish - material balance/imbalance evaluation Tu Ngoc Trung Mon May 28, 2012 3:19 am
            Re: Stockfish - material balance/imbalance evaluation Eelco de Groot Mon May 28, 2012 4:19 am
Post new topic    TalkChess.com Forum Index -> Computer Chess Club: Programming and Technical Discussions

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum




Powered by phpBB © 2001, 2005 phpBB Group
Enhanced with Moby Threads