Do SF still have troubles with 2nd repetitions ?

Discussion of anything and everything relating to chess playing software and machines.

Moderators: hgm, Dann Corbit, Harvey Williamson

Forum rules
This textbox is used to restore diagrams posted with the [d] tag before the upgrade.
jhellis3
Posts: 488
Joined: Fri Aug 16, 2013 10:36 pm

Re: Do SF still have troubles with 2nd repetitions ?

Post by jhellis3 » Mon Mar 23, 2015 8:32 pm

No you don't, you just merge the upstream changes into your branch.

Vinvin
Posts: 4914
Joined: Thu Mar 09, 2006 8:40 am
Full name: Vincent Lejeune

Re: Do SF still have troubles with 2nd repetitions ?

Post by Vinvin » Mon Mar 23, 2015 8:54 pm

Joerg Oster wrote:
Vinvin wrote:
nabildanial wrote:
Vinvin wrote:
nabildanial wrote:A pull request of the fix got rejected in the past despite being favored by Gary and Marco. https://github.com/official-stockfish/Stockfish/pull/80
What a pity !
99% of chess players would think SF is really dumb to not play Nc7 in this position ...
Tell Joona that lol.
I already see the answer "SF is designed to play chess". But SF masters don't know there are 1000 more people who use SF to analyze games than people who use SF to play games ...
Here https://github.com/joergoster/Stockfish ... ae4cce5b7d you can find the necessary patch.
Insert it into the actual sources, compile, and you're done!
Thousands of chess players have to do that ??
That sounds a bit crazy ...

BBauer
Posts: 658
Joined: Wed Mar 08, 2006 7:58 pm

Re: Do SF still have troubles with 2nd repetitions ?

Post by BBauer » Mon Mar 23, 2015 9:12 pm

So you need a branch.

Kind regards
Bernhard

vincenegri
Posts: 73
Joined: Wed Feb 11, 2015 8:19 am

Re: Do SF still have troubles with 2nd repetitions ?

Post by vincenegri » Mon Mar 23, 2015 9:16 pm

Vinvin wrote:
Joerg Oster wrote:
Here https://github.com/joergoster/Stockfish ... ae4cce5b7d you can find the necessary patch.
Insert it into the actual sources, compile, and you're done!
Thousands of chess players have to do that ??
That sounds a bit crazy ...
No, just one motivated one just has to do it and make the binaries and source available for others. Stockfish is open source in part so that this can happen.

carldaman
Posts: 2077
Joined: Sat Jun 02, 2012 12:13 am

Re: Do SF still have troubles with 2nd repetitions ?

Post by carldaman » Mon Mar 23, 2015 9:17 pm

Vinvin wrote:
nabildanial wrote:
Vinvin wrote:
nabildanial wrote:A pull request of the fix got rejected in the past despite being favored by Gary and Marco. https://github.com/official-stockfish/Stockfish/pull/80
What a pity !
99% of chess players would think SF is really dumb to not play Nc7 in this position ...
Tell Joona that lol.
I already see the answer "SF is designed to play chess". But SF masters don't know there are 1000 more people who use SF to analyze games than people who use SF to play games ...
That's right, Vincent. Anything that seriously detracts from the analysis capabilities can't be good and is worth fixing (and possibly worth a couple of lost Elo points, right?). :P
Last edited by carldaman on Mon Mar 23, 2015 9:18 pm, edited 1 time in total.

jhellis3
Posts: 488
Joined: Fri Aug 16, 2013 10:36 pm

Re: Do SF still have troubles with 2nd repetitions ?

Post by jhellis3 » Mon Mar 23, 2015 9:18 pm

Or you could just use Stockfish MateFinder. It is about 10 Elo weaker, but that is only due to a sometimes slower (more robust) search. I keep it updated fairly regularly.

User avatar
Eelco de Groot
Posts: 4279
Joined: Sun Mar 12, 2006 1:40 am
Location: Groningen

Re: Do SF still have troubles with 2nd repetitions ?

Post by Eelco de Groot » Mon Mar 23, 2015 9:18 pm

Vinvin wrote:
Joerg Oster wrote:
Vinvin wrote:
nabildanial wrote:
Vinvin wrote:
nabildanial wrote:A pull request of the fix got rejected in the past despite being favored by Gary and Marco. https://github.com/official-stockfish/Stockfish/pull/80
What a pity !
99% of chess players would think SF is really dumb to not play Nc7 in this position ...
Tell Joona that lol.
I already see the answer "SF is designed to play chess". But SF masters don't know there are 1000 more people who use SF to analyze games than people who use SF to play games ...
Here https://github.com/joergoster/Stockfish ... ae4cce5b7d you can find the necessary patch.
Insert it into the actual sources, compile, and you're done!
Thousands of chess players have to do that ??
That sounds a bit crazy ...
The problem is, I think, an aversity in the Windows community to making an effort to learn some compiling basics, and installing MinGW perhaps. But if that is no problem, I took the liberty of putting Jörg's changes into the very latest sources, so you only have to download a .zip file and then let loose a decent up to date C++11 capable version of MinGW. Daylen Yang has instructions on his site, the official Stockfish site.

The sources are here:

https://github.com/Kingdefender/Stockfi ... repetition

but maybe Jörg wants to do a similar thing. The overall changes are I think negligible from what he posted, I did not check :oops:, just took the today Dev Stockfish and inserted the changes again, by hand.

Eelco
Debugging is twice as hard as writing the code in the first
place. Therefore, if you write the code as cleverly as possible, you
are, by definition, not smart enough to debug it.
-- Brian W. Kernighan

zullil
Posts: 6442
Joined: Mon Jan 08, 2007 11:31 pm
Location: PA USA
Full name: Louis Zulli

Re: Do SF still have troubles with 2nd repetitions ?

Post by zullil » Mon Mar 23, 2015 9:41 pm

Eelco de Groot wrote:, just took the today Dev Stockfish and inserted the changes again, by hand.

Eelco

Code: Select all

-  TimeMgr.init(Limits, RootPos.side_to_move(), RootPos.game_ply());
+  RootPly = RootPos.game_ply();
+  TimeMgr.init(Limits, RootPly, RootPos.side_to_move());
Need to transpose the last two parameters for TimeMgr.init

User avatar
Eelco de Groot
Posts: 4279
Joined: Sun Mar 12, 2006 1:40 am
Location: Groningen

Re: Do SF still have troubles with 2nd repetitions ?

Post by Eelco de Groot » Mon Mar 23, 2015 9:55 pm

zullil wrote:
Eelco de Groot wrote:, just took the today Dev Stockfish and inserted the changes again, by hand.

Eelco

Code: Select all

-  TimeMgr.init(Limits, RootPos.side_to_move(), RootPos.game_ply());
+  RootPly = RootPos.game_ply();
+  TimeMgr.init(Limits, RootPly, RootPos.side_to_move());
Need to transpose the last two parameters for TimeMgr.init
Thanks Louis! I hope I got it right now...
Debugging is twice as hard as writing the code in the first
place. Therefore, if you write the code as cleverly as possible, you
are, by definition, not smart enough to debug it.
-- Brian W. Kernighan

Vinvin
Posts: 4914
Joined: Thu Mar 09, 2006 8:40 am
Full name: Vincent Lejeune

Re: Do SF still have troubles with 2nd repetitions ?

Post by Vinvin » Wed Mar 25, 2015 12:36 pm

jhellis3 wrote:Or you could just use Stockfish MateFinder. It is about 10 Elo weaker, but that is only due to a sometimes slower (more robust) search. I keep it updated fairly regularly.
Nice !
I'll go with your mod ! :-)
Can I get a compile "Windows x64 for modern computers" somewhere ?
Thanks !

Post Reply