Vector problem - square addition

[jhaglund]

Okay, I've been stuck on this far too long...

What I've come up with is this:

Code: Select all

//addsq.hpp
double a_count, b_count, c_count, d_count, e_count, f_count, g_count, h_count;

int i, ii, iii, iv, v, vi, vii, viii;

int *ti = new int;
int *tii = new int;
int *tiii = new int;
int *tiv = new int;
int *tv = new int;
int *tvi = new int;
int *tvii = new int;
int *tviii = new int;

int a, b, c, d, e, f, g, h, j;
int sq_total = 64;

int sq[64] = {
0, 1, 1, 2, 2, 1, 1, 0, 
1, 1, 2, 2, 2, 2, 1, 1,
1, 2, 3, 3, 3, 3, 2, 1,
2, 2, 3, 4, 4, 3, 2, 2,
2, 2, 3, 4, 4, 3, 2, 2,
1, 2, 3, 3, 3, 3, 2, 1, 
1, 1, 2, 2, 2, 2, 1, 1,
0, 1, 1, 2, 2, 1, 1, 0
}; 

/*
add "vertically" every 8 for each file;
a  b     c    d     e   f    g      h
i  ii   iii   iv    v   vi   vii   viii   
8  12    18   22    22  18   12     8


*/

Code: Select all

// addsq.cpp
#include "iostream"
#include "stdio.h"
#include "stdlib.h"
#include "string.h"
#include <cstring>   
#include <algorithm>
#include <vector>

#include "addsq.hpp"
using namespace std;


void add_sq&#40;int& i, int& ii, int& iii, int& iv, int& v, int& vi, int &vii, int &viii&#41;;

int main&#40;)
&#123;
   
        vector<int> myvector &#40;sq, sq+sq_total&#41;;
        a_count = &#40;int&#41; count &#40;myvector.begin&#40;), myvector.end&#40;), sq&#91;a&#93;);
        b_count = &#40;int&#41; count &#40;myvector.begin&#40;), myvector.end&#40;), sq&#91;b&#93;);
        c_count = &#40;int&#41; count &#40;myvector.begin&#40;), myvector.end&#40;), sq&#91;c&#93;);
        d_count = &#40;int&#41; count &#40;myvector.begin&#40;), myvector.end&#40;), sq&#91;d&#93;);
        e_count = &#40;int&#41; count &#40;myvector.begin&#40;), myvector.end&#40;), sq&#91;e&#93;);
        f_count = &#40;int&#41; count &#40;myvector.begin&#40;), myvector.end&#40;), sq&#91;f&#93;);
        g_count = &#40;int&#41; count &#40;myvector.begin&#40;), myvector.end&#40;), sq&#91;g&#93;);
        h_count = &#40;int&#41; count &#40;myvector.begin&#40;), myvector.end&#40;), sq&#91;h&#93;);
        
        a_count = &#40;double&#41; count &#40;sq, sq+sq_total, 0&#41;;
        b_count = &#40;double&#41; count &#40;sq, sq+sq_total, 0&#41;;
        c_count = &#40;double&#41; count &#40;sq, sq+sq_total, 0&#41;;
        d_count = &#40;double&#41; count &#40;sq, sq+sq_total, 0&#41;;
        e_count = &#40;double&#41; count &#40;sq, sq+sq_total, 0&#41;;
        f_count = &#40;double&#41; count &#40;sq, sq+sq_total, 0&#41;;
        g_count = &#40;double&#41; count &#40;sq, sq+sq_total, 0&#41;;
        h_count = &#40;double&#41; count &#40;sq, sq+sq_total, 0&#41;;
     
void add_sq&#40;int&,int&,int&,int&,int&,int&,int&,int&);

a = 0;
b = 1;
c = 2;
d = 3;
e = 4;
f = 5;
g = 6;
h = 7;
  
add_sq&#40;a,b,c,d,e,f,g,h&#41;;
system&#40;"pause");
&#125;


void add_sq&#40;int& i, int& ii, int& iii, int& iv, int& vi, int& vii, int& viii&#41;
&#123;
 
for&#40;j = 0; j < sq_total;) 
&#123;
         
cout << " a " << sq&#91;i&#93;;
cout << " b " << sq&#91;ii&#93;;
cout << " c " << sq&#91;iii&#93;;
cout << " d " << sq&#91;iv&#93;;
cout << " e " << sq&#91;v&#93;;
cout << " f " << sq&#91;vi&#93;;
cout << " g " << sq&#91;vii&#93;;
cout << " h " << sq&#91;viii&#93;;

*ti = i; 
*tii = ii; 
*tiii = iii; 
*tiv = iv; 
*tv = v; 
*tvi = vi;
*tvii = vii;
*tviii = viii;

i = i + 1;
ii = ii + 1;
iii = iii + 1;
iv = iv + 1;
v = v + 1;
vi = vi + 1;
vii = vii + 1;
viii = viii + 1;

cout << " a " << sq&#91;*ti&#93;+sq&#91;i&#93;;
cout << " b " << sq&#91;*tii&#93;+sq&#91;ii&#93;;
cout << " c " << sq&#91;*tiii&#93;+sq&#91;iii&#93;;
cout << " d " << sq&#91;*tiv&#93;+sq&#91;iv&#93;;
cout << " e " << sq&#91;*tv&#93;+sq&#91;v&#93;;
cout << " f " << sq&#91;*tvi&#93;+sq&#91;vi&#93;;
cout << " g " << sq&#91;*tvii&#93;+sq&#91;vii&#93;;
cout << " h " << sq&#91;*tviii&#93;+sq&#91;viii&#93; << endl;
j = j + 1;

 &#125;

&#125; 

I've looked at this for hours...

What I want to do is what it says in "addsq.hpp", add the file values in an array, but simplify it, using a vector, and not this:

Example:

Code: Select all

a = sq[0]+sq[8]+sq[16]+sq[24]+sq[32]+sq[40]+sq[48]+sq[56];
b...
c...
d = sq[3]+sq[11]+sq[19]+sq[27]+sq[35]+sq[43]+sq[51]+sq[59];
...
h = sq[7]+sq[15]+sq[23]+sq[31]+sq[39]+sq[47]+sq[55]+sq[63];

Any help is much appreciated,

Joshua

[smatovic]

not sure if this is what you look for:

Code: Select all

result[8] /* 0-7 => a-h */

for &#40;i =0; i<64; i++)
    result&#91;i-&#40;i&56&#41;&#93;+=sq&#91;i&#93;

[Edmund]

Sorry I don't know enough about the vector class, but if you don't need the values to be 4 bytes long, I would suggest to map a 64 bit variable over the address space and use this to save a couple of instructions.

[jhaglund]

Code: Select all

j = 8;
int n = 0;
int aa = 1;
int result[8]; /* 0-7 => a-h */ 
 
 
for &#40;i =0; i<64; i++) &#123;
    result&#91;i-&#40;i&56&#41;&#93;+=sq&#91;i&#93;;
     cout << sq&#91;i&#93;;  
     n = n + 1;
            if&#40;n==j*aa&#41;&#123;
            aa = aa + 1;
       cout << "" << endl;  
   &#125;      
      
&#125;

Displays the array...

What is result[] doing ?

I want to add the a,b,c,d,e,f,g,h files scores independently and display them...

Thanks though, for your reply though!

Anymore thoughts?

Joshua

[smatovic]

What is result[] doing ?

Assumed the score for an position is stored in sq[] then you got the total score of a file in result[]. Where result[0] is file a and result[7] is file h.

Code: Select all

for &#40;i =0; i<64; i++) &#123;
    result&#91;i-&#40;i&56&#41;&#93;+=sq&#91;i&#93;;
   &#125;     
for &#40;i =0; i<8; i++) &#123;
     cout << result&#91;i&#93;; 
   &#125;     
     
&#125;

Code: Select all

(i&56)

i&56 gives the rank number of the poistion i.

[Edmund]

not sure if this is what you look for:

Code: Select all

result[8] /* 0-7 => a-h */

for &#40;i =0; i<64; i++)
    result&#91;i-&#40;i&56&#41;&#93;+=sq&#91;i&#93;

i-(i&56)

is the same as

i & 7

[jhaglund]

Thanks Srdja,

I had this code tried before your post:

Code: Select all

// addsq.cpp
#include "iostream"

using namespace std;

int main()
{
  int i;
  int result[8];/* 0-7 => a-h */ 
  
  int sq[64] = {
0, 1, 1, 2, 2, 1, 1, 0, 
1, 1, 2, 2, 2, 2, 1, 1,
1, 2, 3, 3, 3, 3, 2, 1,
2, 2, 3, 4, 4, 3, 2, 2,
2, 2, 3, 4, 4, 3, 2, 2,
1, 2, 3, 3, 3, 3, 2, 1, 
1, 1, 2, 2, 2, 2, 1, 1,
0, 1, 1, 2, 2, 1, 1, 0
}; 


for &#40;i =0; i<64; i++) &#123; 
    result&#91;i-&#40;i&56&#41;&#93;+=sq&#91;i&#93;; 
   &#125;      
for &#40;i =0; i<8; i++) &#123; 
     cout << " " << result&#91;i&#93;; 
   &#125;      
      system&#40;"pause");
&#125;

It's output:

//incorrect
1972941486 6492708 6492586 2293582 1972941303 18 12 2293624

//correct
8 12 18 22 22 18 12 8

Simplified, but it displays the wrong results. It has to be something simple?! This is a mini example that goes throughout my program. If I can get this, it will reduce the overall code by the thousands of lines.

Joshua

[jhaglund]

Code:

Code: Select all

result[8] /* 0-7 => a-h */ 

for &#40;i =0; i<64; i++) 
    result&#91;i-&#40;i&56&#41;&#93;+=sq&#91;i&#93; 
 

i-(i&56)

is the same as

i & 7

I'm not familar with this technique. What is this technique called?

[smatovic]

hmm, maybe you should init the result array

Code: Select all

int result[] = {0,0,0,0,0,0,0,0};

[jhaglund]

Thanks for the idea