lucasart wrote:
I'm a bit surprised that Marco is OK with that. But Marco is not the sole copyright holder...
I missed that, my fault. Of course GPL software should remain GPL in its derivates.
lucasart wrote:
That being said, perhaps the author of DON is not aware of these legal "details" and he is not dishonest. I think it's best to start by asking him politely to come clean and restore proper copyright notice and GNU GPL v3.
I just looked at this DON again, and two things struck me:
1/ He now erased all mention of even Glaurung. Before, the readme file at least mentionned Glaurung (even though it is derived from SF).
2/ After having erased all mention of Glaurung/Stockfish (except that he forgot the Makefile), as well as the copyright notice and license agreement, he clearly intends to go commercial wit this project. As you can see in the code he started drafting:
// exe_register() is the command to try to register an engine or to tell the engine that registration
// will be done later. This command should always be sent if the engine has sent "registration error"
// at program startup.
// The following tokens are allowed:
// * later
// the user doesn't want to register the engine now.
// * name <x>
// the engine should be registered with the name <x>
// * code <y>
// the engine should be registered with the code <y>
// Example:
// "register later"
// "register name Stefan MK code 4359874324"
void exe_register (cmdstream &cstm)
{
string token;
if (cstm.good () && (cstm >> token))
{
if (iequals (token, "name"))
{
string name;
// Read name (can contain spaces)
// consume "value" token
while (cstm.good () && (cstm >> token) &&
!iequals (token, "code"))
{
name += whitespace (name) ? token : " " + token;
}
string code;
// Read code (can contain spaces)
while (cstm.good () && (cstm >> token))
{
code += whitespace (code) ? token : " " + token;
}
// TODO::
cout << name << "\n" << code << endl;
}
else if (iequals (token, "later"))
{
// TODO::
}
}
}
Theory and practice sometimes clash. And when that happens, theory loses. Every single time.
lucasart wrote:After having erased all mention of Glaurung/Stockfish (except that he forgot the Makefile), as well as the copyright notice and license agreement, he clearly intends to go commercial wit this project. As you can see in the code he started drafting:
// exe_register() is the command to try to register an engine or to tell the engine that registration
// will be done later. This command should always be sent if the engine has sent "registration error"
// at program startup.
// The following tokens are allowed:
// * later
// the user doesn't want to register the engine now.
// * name <x>
// the engine should be registered with the name <x>
// * code <y>
// the engine should be registered with the code <y>
// Example:
// "register later"
// "register name Stefan MK code 4359874324"
void exe_register (cmdstream &cstm)
{
string token;
if (cstm.good () && (cstm >> token))
{
if (iequals (token, "name"))
{
string name;
// Read name (can contain spaces)
// consume "value" token
while (cstm.good () && (cstm >> token) &&
!iequals (token, "code"))
{
name += whitespace (name) ? token : " " + token;
}
string code;
// Read code (can contain spaces)
while (cstm.good () && (cstm >> token))
{
code += whitespace (code) ? token : " " + token;
}
// TODO::
cout << name << "\n" << code << endl;
}
else if (iequals (token, "later"))
{
// TODO::
}
}
}
lucasart wrote:2/ After having erased all mention of Glaurung/Stockfish (except that he forgot the Makefile), as well as the copyright notice and license agreement, he clearly intends to go commercial wit this project. As you can see in the code he started drafting:
I do not dare to guess why he has added this code, but if he would really want to go commercial it seems rather odd that he publishes "his" code on github.