Problem with Stockfish make signature-profile-build

[zullil]

Code: Select all

Running benchmark for getting the signature ...
sed: -e: No such file or directory
make: *** [embed-signature] Error 1

This much works:

Code: Select all

LZsMacPro-OSX6: ~/Documents/Chess/Stockfish/src] more sign.txt
4769737

[mcostalba]

Code: Select all

Running benchmark for getting the signature ...
sed: -e: No such file or directory
make: *** [embed-signature] Error 1

This much works:

Code: Select all

LZsMacPro-OSX6: ~/Documents/Chess/Stockfish/src] more sign.txt
4769737

it seems 'sed' is not installed on your ssetup

[zullil]

Code: Select all

Running benchmark for getting the signature ...
sed: -e: No such file or directory
make: *** [embed-signature] Error 1

This much works:

Code: Select all

LZsMacPro-OSX6: ~/Documents/Chess/Stockfish/src] more sign.txt
4769737

it seems 'sed' is not installed on your ssetup

Hi Marco,

sed is certainly available:

Code: Select all

LZsMacPro-OSX6: ~/Documents/Chess/Stockfish/src] which sed
/usr/bin/sed
LZsMacPro-OSX6: ~/Documents/Chess/Stockfish/src] more sign.txt 
4769737
LZsMacPro-OSX6: ~/Documents/Chess/Stockfish/src] sed -i -e 's,^,/static const string Version/s/"\\(.*\\)"/"sig-,1' -e 's,$$,"/1,1' sign.txt
sed: -e: No such file or directory

[zullil]

This works for me:

Code: Select all

embed-signature:
        @echo "Running benchmark for getting the signature ..."
        @$(SIGNBENCH) 2>&1 | sed -n 's/Nodes searched  : \(.*\)/\1/p' > sign.txt
        @sed -i '' -e 's,^,/static const string Version/s/"\\(.*\\)"/"sig-,1' -e 's,$$,"/1,1' sign.txt
        @sed -i '' -f sign.txt misc.cpp
        @rm sign.txt

Code: Select all

LZsMacPro-OSX6: ~/Documents/Chess/Stockfish/src] ./stockfish  
Stockfish sig-4769737 64 SSE4.2 by Tord Romstad, Marco Costalba and Joona Kiiski

[mcostalba]

This works for me:

Unfortunately not for me.

Could you please test the following ?

Code: Select all

embed-signature:
	@echo "Running benchmark for getting the signature ..."
	@$(SIGNBENCH) 2>&1 | sed -n 's/Nodes searched  : \(.*\)/\1/p' > sign.txt
	@sed -e 's,^,/static const string Version/s/"\\(.*\\)"/"sig-,1' -e 's,$$,"/1,1' -i sign.txt
	@sed -f sign.txt -i misc.cpp
	@rm sign.txt

[zullil]

This works for me:

Unfortunately not for me.

Could you please test the following ?

Code: Select all

embed-signature:
	@echo "Running benchmark for getting the signature ..."
	@$(SIGNBENCH) 2>&1 | sed -n 's/Nodes searched  : \(.*\)/\1/p' > sign.txt
	@sed -e 's,^,/static const string Version/s/"\\(.*\\)"/"sig-,1' -e 's,$$,"/1,1' -i sign.txt
	@sed -f sign.txt -i misc.cpp
	@rm sign.txt

Already tried that, and it didn't work. But I'll try again to be sure.

No good here:

Code: Select all

Running benchmark for getting the signature ...
sed: -i may not be used with stdin
make: *** [embed-signature] Error 1

[zullil]

How about this?

Code: Select all

embed-signature: 
        @echo "Running benchmark for getting the signature ..." 
        @$(SIGNBENCH) 2>&1 | sed -n 's/Nodes searched  : \(.*\)/\1/p' > sign.txt 
        @sed -i .bak -e 's,^,/static const string Version/s/"\\(.*\\)"/"sig-,1' -e 's,$$,"/1,1' sign.txt 
        @sed -i .bak -f sign.txt misc.cpp 
        @rm sign.txt *.bak 

[Sven]

How about this?

Code: Select all

embed-signature: 
        @echo "Running benchmark for getting the signature ..." 
        @$(SIGNBENCH) 2>&1 | sed -n 's/Nodes searched  : \(.*\)/\1/p' > sign.txt 
        @sed -i .bak -e 's,^,/static const string Version/s/"\\(.*\\)"/"sig-,1' -e 's,$$,"/1,1' sign.txt 
        @sed -i .bak -f sign.txt misc.cpp 
        @rm sign.txt *.bak 

I found this link which explains the problem, i.e. "sed -i" behaves differently on Mac OS X than on Linux.

@Marco: maybe on Makefile level the "-i" option could be replaced by a variable like SED_INPLACE_OPTION expanding to "-i" on Linux and other platforms where this works, but to "-i .bak" on Mac OS X. Or something similar. It would in fact be a configure issue.

Sven

[mcostalba]

Ok, I have modified sed command to write the file in one go, this should work although is ugly as hell

Code: Select all

embed-signature:
	@echo "Running benchmark for getting the signature ..."
	@$(SIGNBENCH) 2>&1 | sed -n 's/Nodes searched  : \(.*\)/\/string Version\/s\/"\\(.*\\)"\/"sig-\1"\//p' > sign.txt
	@sed -f sign.txt -i misc.cpp
	@rm sign.txt

Could you please verify ?

[zullil]

Ok, I have modified sed command to write the file in one go, this should work although is ugly as hell

Code: Select all

embed-signature:
	@echo "Running benchmark for getting the signature ..."
	@$(SIGNBENCH) 2>&1 | sed -n 's/Nodes searched  : \(.*\)/\/string Version\/s\/"\\(.*\\)"\/"sig-\1"\//p' > sign.txt
	@sed -f sign.txt -i misc.cpp
	@rm sign.txt

Could you please verify ?

Fails here, as before:

Code: Select all

Running benchmark for getting the signature ...
sed: -i may not be used with stdin
make: *** [embed-signature] Error 1