Hi Alex-RegicideX wrote:I agree -- and I would ask everyone to be civil about this.Dr.Wael Deeb wrote:With all my respect,we don't need yet another Rybka flamewar thread....
We've had more than enough....
But people are forming an opinion about the similarity of two pieces of code by studying source code that was modified to look more similar than it is. This is not right.
Names are in fact different -- but making them similar anyway is understandable. But changing the order of variable declaration, the order of variable initialization and the order of "if" statements is a bit too much. This on top of the fact that various blocks of code do not actually correspond to each other.
I think it's important to point this out given that the good name of a programmer is involved.
according to the legal sources we consulted:
- it is perfectly correct and legally sound to reconstruct the source code and make it appear as similar as possible as long as the semantics of are left untouched
http://www.linux.com/feature/113252/
i.e. you can and must move instructions around, pick variable names and use any formatting you see fit in order to make the reconstructed code look as similar as possible. However, you must not change the semantics.
The reconstructed code, when compiled and run, must work exactly as the original.
for ex: this means that
bool variable = 1;
is the same as
bool variable = true;
or if the same line of code appears on line 26 in one source, but on line 28 in another source...it doesn't mean the comparison in suddenly invalid.
if the lines of code are semantically identical, and the order of variable declarations is meaningless, then aligning two lines of code that are the same next to each other only aids the comparison.