Why is Stockfish removing killer moves in move ordering ?

Discussion of chess software programming and technical issues.

Moderators: chrisw, Rebel, Ras

User avatar
Paul JF
Posts: 9
Joined: Tue Aug 02, 2022 9:33 pm
Full name: Paul Jérôme--Filio

Why is Stockfish removing killer moves in move ordering ?

Post by Paul JF »

From this commit https://github.com/official-stockfish/S ... 790ee56176, Stockfish stops using killer moves in move ordering. Why ? I thought it was in important piece of move ordering, am I right ? Even is Stockfish can manage to have few more wins against itself, it is something "usual" to have killer moves, I do not understand why they remove it.
User avatar
shawn
Posts: 95
Joined: Fri Jun 28, 2024 9:24 am
Full name: Wallace Shawn

Re: Why is Stockfish removing killer moves in move ordering ?

Post by shawn »

It was removed because it accounts for many lines of code but doesn't account for any strength. IMO the reason that it doesn't gain elo anymore is both due to the improvements in history heuristics over the years and advancements in NNUE making the minor slowdown of removing one movepicker stage even more negligible.
Viz
Posts: 223
Joined: Tue Apr 09, 2024 6:24 am
Full name: Michael Chaly

Re: Why is Stockfish removing killer moves in move ordering ?

Post by Viz »

Paul JF wrote: Tue Jul 23, 2024 9:16 pm From this commit https://github.com/official-stockfish/S ... 790ee56176, Stockfish stops using killer moves in move ordering. Why ? I thought it was in important piece of move ordering, am I right ? Even is Stockfish can manage to have few more wins against itself, it is something "usual" to have killer moves, I do not understand why they remove it.
because they don't do anything any longer (strength-wise)? No matter how "usual" smth is if it is useless stockfish will remove it. And it was done before a lot of times.
For example IID was a "usual" thing but completely useless once you get to 3000 CCRL strength. Or check extensions. Or (a lot of other things).
AndrewGrant
Posts: 1934
Joined: Tue Apr 19, 2016 6:08 am
Location: U.S.A
Full name: Andrew Grant

Re: Why is Stockfish removing killer moves in move ordering ?

Post by AndrewGrant »

The passage of time necessitates revisiting previous decisions.
When you can't win an argument, you censor it.
When you can't win an election, you remove your opponents.
Just because you've been doing something for a long time, does not mean you are any good at it.
mar
Posts: 2625
Joined: Fri Nov 26, 2010 2:00 pm
Location: Czech Republic
Full name: Martin Sedlak

Re: Why is Stockfish removing killer moves in move ordering ?

Post by mar »

Viz wrote: Wed Jul 24, 2024 6:23 am For example IID was a "usual" thing but completely useless once you get to 3000 CCRL strength. Or check extensions. Or (a lot of other things).
I wonder since by removing check extensions the engine will be severely crippled tactically
AndrewGrant
Posts: 1934
Joined: Tue Apr 19, 2016 6:08 am
Location: U.S.A
Full name: Andrew Grant

Re: Why is Stockfish removing killer moves in move ordering ?

Post by AndrewGrant »

mar wrote: Wed Jul 24, 2024 7:45 am
Viz wrote: Wed Jul 24, 2024 6:23 am For example IID was a "usual" thing but completely useless once you get to 3000 CCRL strength. Or check extensions. Or (a lot of other things).
I wonder since by removing check extensions the engine will be severely crippled tactically
I wonder if <the opposite of the thing that was measured to not happen in order to make the decision> will happen
When you can't win an argument, you censor it.
When you can't win an election, you remove your opponents.
Just because you've been doing something for a long time, does not mean you are any good at it.
Viz
Posts: 223
Joined: Tue Apr 09, 2024 6:24 am
Full name: Michael Chaly

Re: Why is Stockfish removing killer moves in move ordering ?

Post by Viz »

mar wrote: Wed Jul 24, 2024 7:45 am
Viz wrote: Wed Jul 24, 2024 6:23 am For example IID was a "usual" thing but completely useless once you get to 3000 CCRL strength. Or check extensions. Or (a lot of other things).
I wonder since by removing check extensions the engine will be severely crippled tactically
I wonder if severely tactically crippled engine would be able to pass non-reg SPRT vs severely better tactical engine.
My guess would be no, since it only means that this doesn't happen.
mar
Posts: 2625
Joined: Fri Nov 26, 2010 2:00 pm
Location: Czech Republic
Full name: Martin Sedlak

Re: Why is Stockfish removing killer moves in move ordering ?

Post by mar »

AndrewGrant wrote: Wed Jul 24, 2024 7:47 am I wonder if <the opposite of the thing that was measured to not happen in order to make the decision> will happen
I still remember a game a couple of years ago where SF lost to Weiss in TCEC exactly due to missing some tactics - so it may happen

also some people use engines for analysis

elo is not the best way to measure tactical blindness since it correllates with that works most of the time
Ciekce
Posts: 171
Joined: Sun Oct 30, 2022 5:26 pm
Full name: Conor Anstey

Re: Why is Stockfish removing killer moves in move ordering ?

Post by Ciekce »

mar wrote: Wed Jul 24, 2024 7:45 am I wonder since by removing check extensions the engine will be severely crippled tactically
source: I made it up
AndrewGrant
Posts: 1934
Joined: Tue Apr 19, 2016 6:08 am
Location: U.S.A
Full name: Andrew Grant

Re: Why is Stockfish removing killer moves in move ordering ?

Post by AndrewGrant »

mar wrote: Wed Jul 24, 2024 7:59 am
AndrewGrant wrote: Wed Jul 24, 2024 7:47 am I wonder if <the opposite of the thing that was measured to not happen in order to make the decision> will happen
I still remember a game a couple of years ago where SF lost to Weiss in TCEC exactly due to missing some tactics - so it may happen

also some people use engines for analysis

elo is not the best way to measure tactical blindness since it correllates with that works most of the time
you'll be hard pressed to show that one patch has a material impact and not just chance, on a particular position.
nothing you wrote is based in any fact or science, where as the removal of the concept is. So I defer to science.
When you can't win an argument, you censor it.
When you can't win an election, you remove your opponents.
Just because you've been doing something for a long time, does not mean you are any good at it.